-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Integrated OpenDataHub Centralized Custom Certificate #166
[Feature] Integrated OpenDataHub Centralized Custom Certificate #166
Conversation
Signed-off-by: jooho <jlee@redhat.com>
Signed-off-by: jooho <jlee@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update kserve customcacert controller logic Signed-off-by: jooho <jlee@redhat.com>
07a49b5
to
33b691b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current reconciliation logic looks fine but could I request you to please write in similiar pattern that we follow in other reconciler like below. It help us to maintain uniformity in code and its more robust.
@Jooho I am not following whole centralized cert story from begining, Could I ask Who is responsible to create If its created by some other operator like |
Signed-off-by: jooho <jlee@redhat.com>
Signed-off-by: jooho <jlee@redhat.com>
5f39514
to
1f34cc0
Compare
Signed-off-by: jooho <jlee@redhat.com>
Signed-off-by: jooho <jlee@redhat.com>
dd505f8
to
00a33a5
Compare
@vaibhavjainwiz I agree. Therefore, I have accepted your recommendation and made significant changes to the source code accordingly. Please review.
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the PR looks good to me, just a couple of comments to clarify impact on existing code
Signed-off-by: jooho <jlee@redhat.com>
Signed-off-by: jooho <jlee@redhat.com>
changes looks good to me as well. I had reviewed it by dry run on code. |
/lgtm |
@danielezonca I found the root cause why the old logic was working. I fixed it with #167 and it will be included. |
This pr had to be squeezed and merged. I will do it manually. |
Description
OpenDataHub Centralized Cert PR has been merged.
KServe can now integrate with the centralized certificate as a result of this change.
This PR facilitates the update of the storage-config secret, which includes the custom certificate.
More details about the issue can be found here.
How Has This Been Tested?
Setup
Manual
Script
(NOTE) This was tested on fedora only.
Set root.crt path
TEST
1. Create a dataconnection
1-1. without global cert
1-2. with global cert
2. Update global cert
3. KServe test
4. ModelMesh test
Clean up demo
Merge criteria: